Skip to content

e2e(docs) add initial tests #7728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

Shane-Donlon
Copy link
Contributor

@Shane-Donlon Shane-Donlon commented Jul 15, 2025

What is it?

  • E2E Tests

Description

Hey guys,
Thought I'd get the ball rolling on some playwright tests.

Current status is 124 tests - but majority are only page loading tests.

As such I'm only running them in chrome for now as it's pretty much testing network responses.

Leaving this in draft for now as I'm unsure how exactly this is to be implemented.

Checklist

  • [ x] My code follows the developer guidelines of this project
  • [ x] I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • [ x] I added new tests to cover the fix / functionality

TODO:

There's more to do but some general pointers as to what is remaining.

  • Tutorial e2e tests
  • Qwik Sandbox
  • Blog
  • Theme switcher

Copy link

changeset-bot bot commented Jul 15, 2025

⚠️ No Changeset found

Latest commit: 1bdcf2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1bdcf2d

@wmertens
Copy link
Member

This is great, but for me the big one is the sandbox, where we'd want to test that:

  • the "app" actually loads
  • the html etc tabs works
  • changing the code updates the app

Copy link

pkg-pr-new bot commented Aug 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7728
npm i https://pkg.pr.new/@builder.io/qwik-city@7728
npm i https://pkg.pr.new/eslint-plugin-qwik@7728
npm i https://pkg.pr.new/create-qwik@7728

commit: 1bdcf2d

@Shane-Donlon
Copy link
Contributor Author

This is great, but for me the big one is the sandbox, where we'd want to test that:

  • the "app" actually loads
  • the html etc tabs works
  • changing the code updates the app

Thanks & acknowledged.

In terms of the sandbox testing the "hello world" section has been done.
I'll keep plugging away at the other sections too, once the whole sandbox has been covered I'll mark this for review.

image

@Shane-Donlon
Copy link
Contributor Author

Things to note re: sandbox testing.

  • Auto complete sandbox example does not work on the qwik.dev live site.
  • I am testing that the page loads, but cannot test the API response etc..
  • Will need to create a new issue later on this.
  • raised on Discord to chat about it first.

On the clock page

  • Cannot test paragraph on click
  • Presumably playwright on clicks on buttons links etc.. but I did try to add a test and it would always fail.
  • In short cannot test that the below console.log works.
image

in the routing.spec.ts file,

  • I am testing against the URL change only for now.

The page title is inconsistent to test against, will need to log a new issue against this.
But the bones are setup so once that is resolved it's not a big change.

Current Status:
211 tests - all pass using 1 worker, I did have some timing issues running 8 workers locally.

image />

@Shane-Donlon Shane-Donlon marked this pull request as ready for review August 21, 2025 15:14
@Shane-Donlon Shane-Donlon requested a review from a team as a code owner August 21, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants